Make spec_test idempotent #16392
Merged
Make spec_test idempotent #16392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was actually saving the content over existing spec files. So everytime that you ran the test the files would have be modified and you had to ignore them on commit. This commit move the generated file into a temporary directory.
|
Pinging @elastic/ingest (Project:fleet) |
|
@michalpristas If you have can you take a look at this? |
michalpristas
approved these changes
Feb 24, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
The previous implementation was actually saving the content over existing spec files. So everytime that you ran the test the files would have be modified and you had to ignore them on commit. This commit move the generated file into a temporary directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was actually saving the content over existing
spec files. So everytime that you ran the test the files would have be
modified and you had to ignore them on commit.
This commit move the generated file into a temporary directory.